Add a retry block when hosts are added to replset #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a race condition here where, if the master has changed since the replset host add will fail. This happens during scale out of nodes or when master is being migrated. Adding a retry block here will give the hosts a chance to join the cluster while the master is coming up.
jistr
reviewed
Jan 5, 2018
| output = {} | ||
| output = rs_arbiter == host ? rs_add_arbiter(host, master) : rs_add(host, master) | ||
| retry_limit.times do |n| | ||
| begin |
There was a problem hiding this comment.
We can drop lines 246, 257 (new begin-end scope block is implied by the times do |n| loop)
| Puppet.debug "Retry adding host to replicaset. Retry: #{n}" | ||
| sleep retry_sleep | ||
| master = master_host(alive_hosts) | ||
| next |
There was a problem hiding this comment.
I think we can drop the next too, as it doesn't skip anything and the loop will progress to the next iteration by itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a race condition here where, if the master has changed since
the replset host add will fail. This can happen when scaling out of nodes
or when master is being migrated.
Adding a retry block here will give the hosts a chance to join the
cluster while the master is coming up.