add gsub to replace invalid json values with a 1

[TomRitserveldt]

See issue: #447

[rnelson0]

I do not imagine it would cause a problem, but can anyone confirm that with MongoDB <3.6.3, this change will cause no issues?

[TomRitserveldt]

The initial change did not work for mongodb 3.2.x, I commit a new change now that moved the gsub to the mongo_eval function, since there was already something similar in place there, and in the replset function.

I merged those "dirty" fixes into the mongo_eval function so the same fix does not need to be applied everywhere seperatly. I tested this change on mongo 3.2.x and 3.6.x and it both worked fine.

should be good to merge like this @rnelson0

[rnelson0]

It looks like `out.gsub!(%r{\w+\((.+?)\)}, '\1')` is present in two locations now. Should the instance in the second file, where you removed just one line, also be removed? -- Rob Nelson

[TomRitserveldt]

@rnelson0 sorry for late reply, yes that line is present in 2 locations, for some reason that I havent been able to find out, the tests fail when it is not present in both locations.. I've been through the code but I can't see why since it just uses the same function as far as I can tell.

So this just works.

[TomRitserveldt]

Could someone re-review this PR and merge it?
The reason the tests would fail without the gsub in the second file was that the mocked mongo_eval data contained invalid json, while the whole point of this PR was to let mongo_eval output sanitized json data.
I changed the invalid mocked json to valid json now, which should solve the concern @rnelson0 had.

[bastelfreak]

@rnelson0 can you take a look again please?

[vStone]

I would pull out the 'sanitation' into a separate function and then we could write some tests against that.

Totally unrelated to the pull request but:
With the current regexes I noticed we might be swallowing some values:

{
  "blalba": SomeType(123),
  "time": Timestamp(456, 1)
}

The first regex will result in:

1. | 12
2. | 456

(Notice the 3 being stripped from 123.

[vStone]

This feels.. dirty. Maybe implement it like https://github.com/voxpupuli/puppet-mongodb/blob/master/lib/puppet/provider/mongodb_conn_validator/tcp_port.rb#L1