Handle non-existing config file #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhollinger
approved these changes
Jun 15, 2018
dhollinger
requested changes
Jun 15, 2018
ekohl
force-pushed
the
handle-different-config-location
branch
from
ea7ed63
to
6455280
Compare
|
Updated to include a refactoring. Rubocop was right that there was way too much nesting. |
When using the RH MongoDB 3.4 SCL the config file is in /etc/opt/rh/rh-mongodb34/mongod.conf which causes this fact to fail because the -syspaths package still installs the binaries to /usr/bin. Since we don't use this fact, it's enough for now to gracefully handle this. Ideally we could use the value for mongodb::server::config but I'm not aware of a way to do this in facts.
ekohl
force-pushed
the
handle-different-config-location
branch
from
6455280
to
991af66
Compare
|
💚 now |
bastelfreak
approved these changes
Jun 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the RH MongoDB 3.4 SCL the config file is in /etc/opt/rh/rh-mongodb34/mongod.conf which causes this fact to fail because the -syspaths package still installs the binaries to /usr/bin. Since we don't use this fact, it's enough for now to gracefully handle this.
Ideally we could use the value for mongodb::server::config but I'm not aware of a way to do this in facts.