-
-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for mongodb versions before 2.6 #504
Conversation
|
I considered dropping the old config file format but it may break on upgrades when the file hasn't been rewritten yet: puppet-mongodb/lib/facter/is_master.rb Lines 21 to 37 in ea3feb2
|
| end | ||
| cmd_json = <<-EOS.gsub(%r{^\s*}, '').gsub(%r{$\n}, '') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll rewrite this with a .to_json as well in a separate PR in a separate PR.
| @@ -133,7 +92,7 @@ def password_hash=(_value) | |||
| end | |||
|
|
|||
| def password=(value) | |||
| if mongo_24? || mongo_26? | |||
| if mongo_26? | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs indicate this method should also work on 3.x and 4.x but I'll look into that later when I have acceptance tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not an expert for types and providers, but this looks good to me and also the tests pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not super familiar with mongo, but I didn't see any obvious red flags or things that made me stop and think "Now why is it done this way...?"
And, the tests and checks pass.
No description provided.