Refactor client handling #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
force-pushed
the
refactor-client
branch
2 times, most recently
from
fbf5d0b
to
f73325a
Compare
This removes the boolean value for ensure and only allows a string. It also introduces a separate params file just for the client to simplify the main params file.
ekohl
force-pushed
the
refactor-client
branch
from
f73325a
to
dd7a8c6
Compare
bastelfreak
reviewed
Dec 1, 2018
Co-Authored-By: ekohl <ewoud@kohlvanwijngaarden.nl>
bastelfreak
reviewed
Dec 1, 2018
Co-Authored-By: ekohl <ewoud@kohlvanwijngaarden.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.