Describe disabling logpath to make syslog work #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was confused about how to make the `syslog` config work because, even though I had not set `logpath`, the default value kept `syslog` from working. I tried setting it to an empty string, but that failed with a failed pattern check. I had to look into the code to find out that I can also set it to `false` and that made it work.
ekohl
approved these changes
Jul 18, 2020
|
Wow that was fast! Thank you and thank you for all the work you all put into this module. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
I was confused about how to make the
syslogconfig work because, even though I had not setlogpath, the default value keptsyslogfrom working. I tried setting it to an empty string, but that failed with a failed pattern check.I had to look into the code to find out that I can also set it to
falseand that made it work.This Pull Request (PR) fixes the following issues
n/a