Use rs.secondaryOk on versions that deprecated rs.slaveOk #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like a cleaner implementation than #593 since it gracefully falls back. At first glance it looks ok, but I'll wait for the tests to complete |
rs.slaveOk has been deprecated and warnings are all over the place e.g. in the mongodb_is_master fact. Which makes the fact and /root/.mongrc.js unusable. Use rs.secondaryOK by default and fall back gracefully on versions which only support rs.slaveOk yet.
svenbs
force-pushed
the
fix-mongodb-slaveok
branch
from
440bc34
to
80f47d5
Compare
|
@ekohl : I've merged my changes into a single commit and also rebased on |
ekohl
changed the title
This was referenced Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
rs.slaveOk has been deprecated since version 3.6.20 and others. Warnings are all over the place e.g.
in the mongodb_is_master fact. Which makes the fact and
/root/.mongrc.jsunusable.Using a try-catch block to use the new command rs.secondaryOK() by default and fall back to rs.slaveOK() fixes this.