Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Puppet-Datatype Sensitive for Passwords #611

Merged

Conversation

cocker-cc
Copy link
Contributor

  • let Function mongodb_password() accept Parameter password of Datatype Sensitive
  • add Parameter "sensitive" to Function mongodb_password to decide if its Returnvalue should be of Datatype Sensitive
  • let defined Type mongodb::db accept Datatype Sensitive for $password_hash and $password
  • let Class mongodb::server accept Datatype Sensitive for $key and $admin_password

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@kenyon
Copy link
Member

kenyon commented Jun 14, 2021

Looks like we need some help with #602 to get those CentOS tests to pass.

@kenyon kenyon added the enhancement New feature or request label Jun 14, 2021
@cocker-cc cocker-cc force-pushed the Use_Puppet-Datatype_Sensitive branch from a3cbb90 to 0e8209f Compare June 14, 2021 08:15
@cocker-cc
Copy link
Contributor Author

@kenyon

Looks like we need some help with #602 to get those CentOS tests to pass.

#1396.5 failed

"message":"toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit"

I guess, there is not much I can help with…

@kenyon
Copy link
Member

kenyon commented Jun 14, 2021

#602 changes tests to use GitHub Actions instead of Travis, where we don't have the Docker Hub rate limit problem.

@cocker-cc cocker-cc force-pushed the Use_Puppet-Datatype_Sensitive branch 2 times, most recently from b69afa4 to 1962aef Compare June 22, 2021 22:37
@cocker-cc cocker-cc force-pushed the Use_Puppet-Datatype_Sensitive branch 2 times, most recently from 65033af to 418ff43 Compare July 13, 2021 10:21
@root-expert
Copy link
Member

Hello @cocker-cc, can you rebase with our master branch? This will allow the CI to run.

- let Function mongodb_password() accept Parameter password of Datatype Sensitive
- add Parameter "sensitive" to Function mongodb_password to decide if its Returnvalue should be of Datatype Sensitive
- let defined Type mongodb::db accept Datatype Sensitive for $password_hash and $password
- let Class mongodb::server accept Datatype Sensitive for $key and $admin_password
@cocker-cc cocker-cc force-pushed the Use_Puppet-Datatype_Sensitive branch from 418ff43 to 1248d0c Compare August 20, 2021 20:16
@cocker-cc
Copy link
Contributor Author

Hello @cocker-cc, can you rebase with our master branch? This will allow the CI to run.

Done.

@root-expert root-expert merged commit 35ea6f3 into voxpupuli:master Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants