Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mongodb_user ignores database parameter when removing a user #644

Merged
merged 1 commit into from
Sep 18, 2022

Conversation

SeanHood
Copy link
Contributor

@SeanHood SeanHood commented Jul 7, 2022

Pull Request (PR) description

Currently setting ensure => absent for a user doesn't work for users created in other databases than admin

This Pull Request (PR) fixes the following issues

This PR fixes this by passing the database value to mongo_eval

@SeanHood
Copy link
Contributor Author

SeanHood commented Jul 7, 2022

I have a feeling, this patch needs to be applied to get tests running. Should this be in this PR or a separate one?

diff --git a/.fixtures.yml b/.fixtures.yml
index 9937c6d..97dc093 100644
--- a/.fixtures.yml
+++ b/.fixtures.yml
@@ -1,7 +1,7 @@
 fixtures:
   repositories:
-    "stdlib": "git://github.com/puppetlabs/puppetlabs-stdlib.git"
-    "apt": "git://github.com/puppetlabs/puppetlabs-apt.git"
+    "stdlib": "https://github.com/puppetlabs/puppetlabs-stdlib.git"
+    "apt": "https://github.com/puppetlabs/puppetlabs-apt.git"
     "systemd": "https://github.com/voxpupuli/puppet-systemd.git"
     "zypprepo": "https://github.com/voxpupuli/puppet-zypprepo.git"
     yumrepo_core:

@smortex
Copy link
Member

smortex commented Jul 8, 2022

I just merged #643 which include it. Let's re-trigger a build

@smortex
Copy link
Member

smortex commented Jul 8, 2022

Hum, one day I will understand what GitHub does with the repo before running CI. I though it would merge the branch and the main branch but it seems not to…

Can you please rebase your changes on top of the main branch?

From your working directory:

git fetch origin       # Download the latest code we have here
git rebase origin/master # Move your commits on top of the main branch
git push -f            # Send the changes (-f is required because we re-wrote history)

Thanks!

@SeanHood
Copy link
Contributor Author

SeanHood commented Jul 8, 2022

Different failures, I'll take a look at those now.

Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not a user of this module so I will let another Vox member approve and merge this. Thanks!

@root-expert root-expert added the bug Something isn't working label Sep 18, 2022
@root-expert root-expert changed the title Fix: User isn't removed from non-admin database mongodb_user ignores database parameter when removing a user Sep 18, 2022
@root-expert root-expert merged commit a4814d3 into voxpupuli:master Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants