Catch errors on database creation or destroy #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for the PR! can you please rebase against our master branch? #664 should fix the CentOS CI problems. |
|
Hmm not sure if I did it correct but you can always squash commit this into |
|
please do an actual rebase and don't merge master :) this will provide a cleaner git history. The problem with github is there is no 'please do a rebase and run CI and only merge when CI passes' button, so I cannot rebase it for you :( If you've questions about it, you can join our IRC channel #voxpupuli on Libera.chat or our slack channel #voxpupuli at https://slack.puppet.com/. |
JvGinkel
force-pushed
the
dberrors
branch
2 times, most recently
from
04c3c75
to
413503a
Compare
bastelfreak
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Don't ignore the DB creation or destroy command results but raise a message on errors.
This Pull Request (PR) fixes the following issues
Fixes #651