Remove nojournal parameter; Cleanup journal management #730
Conversation
h-haaks
force-pushed
the
cleanup-journaling-config
branch
from
2b8f4b0
to
70d2086
Compare
|
Resolves mongodb 7 issues in #728 |
manifests/server.pp
Outdated
| if $journal != undef { | ||
| if ($mongodb::globals::manage_package_repo and versioncmp($mongodb::globals::repo_version, '7.0') >= 0) | ||
| or ($package_ensure =~ /\./ and versioncmp($package_ensure, '7.0.0') >= 0 ) { | ||
| fail('`journal` parameter is only supported for MongoDB < 7.0') | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Does this mean that mongodb::globals::repo_version needs to be set or the package_ensure variable needs to be set to a version for this validation to work? The validation is just skipped when someone manages their own repo, right?
There was a problem hiding this comment.
The validation is just skipped when someone manages their own repo
That was my intention. We can't validate something we don't know about.
I added the version constraint in param doc just for this.
But I now see that there is a small bug.
When we bump the default to 7.0 this will start to fail even if repo_locationis set.
I'll check that repo_location is undef as well.
There was a problem hiding this comment.
Fixed and enhanced by looking for a version match in provided repo_location as well.
Added a few more tests.
h-haaks
force-pushed
the
cleanup-journaling-config
branch
2 times, most recently
from
97c701a
to
866e298
Compare
h-haaks
force-pushed
the
cleanup-journaling-config
branch
from
866e298
to
b6dcd67
Compare
Pull Request (PR) description
Removing duplicate param to manage
storage.journal.enabledUsage of
nojournal => truemust be changed tojournal => falseIn addition
storage.journal.enabledis removed in mongodb 7