New parameter out_all, default false #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was unsure how you like to do parameter testing in spec files , happy to follow another strategy if you can point me at one. |
duritong
reviewed
Oct 13, 2020
|
I started adding some strings docs as well. |
|
Could you rebase on latest master? @keachi PTAL |
In order to allow all outbound traffic a parameter is added to enable a simple `allow` entry on the out chain. Default is false so backwards compatible. If true all the other out_bound rules (ntp, ...) will be disabled since not needed.
|
rebased and squashed also. |
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to allow all outbound traffic a parameter is
added to enable a simple
allowentry on the out chain.Default is false so backwards compatible.