Allow declaring the same set in several tables #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbarrientos
force-pushed
the
issue100
branch
2 times, most recently
from
22b579e
to
9d4fa9c
Compare
duritong
approved these changes
Jul 6, 2021
traylenator
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset supercharges the
tableparameter ofnftables::setto allow passing either aStringfor a single table (to maintain backwards compatibility) or anArray[String]. The second option allows hence to declare the same set in several tables in one go.I'm adding as well an extra element to the "all rules" acceptance check to make sure that it's fine to use the new functionality to declare a single set in multiple tables.
Closes #100