support a different table name for 'nat' #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@traylenator @nbarrientos |
nbarrientos
reviewed
Aug 31, 2021
nbarrientos
reviewed
Aug 31, 2021
|
Apart from those two small comments LGTM. Requesting review from @duritong |
duritong
requested changes
Aug 31, 2021
duritong
reviewed
Sep 2, 2021
- Some applications (such as libvirt) still use iptables to inject firewall rules - iptables will refuse to update tables that were initially created with nft - This commit allows defining the name of the 'nat' table in order to avoid namespace conflicts
figless
force-pushed
the
nat_table_name
branch
from
e4d99bf
to
fcb79d7
Compare
nbarrientos
approved these changes
Sep 7, 2021
duritong
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rules
namespace conflicts
Note: pull request #105 was raised previously, however was closed due to an erroneous force push to the forked project. Please check this pull request for the full change history.