rspec mock systemd process on docker #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traylenator
force-pushed
the
systemd
branch
2 times, most recently
from
d8e39a2
to
85f095d
Compare
bastelfreak
reviewed
Mar 8, 2022
spec/spec_helper.rb
Outdated
| c.before do | ||
| # select the systemd service provider even when on docker | ||
| # https://tickets.puppetlabs.com/browse/PUP-11167 | ||
| if defined?(facts) and %w[Archlinux RedHat].include?(facts[:os]['family']) |
There was a problem hiding this comment.
why limit to to those two OSes? shouldn't we do it on all?
There was a problem hiding this comment.
Was thinking someone might add slackware at some future date and then you might get the wrong service provider.
Archlinux, RedHat is everything in metadata.yml today so for sure not against changing.
On docker rspec the service provider is autodetected as redhat rather than systemd. https://tickets.puppetlabs.com/browse/PUP-11167 That causes ``` error during compilation: Parameter enable failed on Service[firewalld]: Provider redhat must have features 'maskable' to set 'enable' to 'mask' (file: /builds/ai/it-puppet-module-nftables/code/spec/fixtures/modules/nftables/manifests/init.pp, line: 186) ``` mock the systemd process so that the systemd provider is used.
nbarrientos
approved these changes
Mar 9, 2022
There was a problem hiding this comment.
LGTM. Won't merge, though. Waiting for @bastelfreak's pending comment.
bastelfreak
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
On docker rspec the service provider is autodetected as redhat
rather than systemd.
https://tickets.puppetlabs.com/browse/PUP-11167
That causes
mock the systemd process so that the systemd provider is used.
Also migrate existing mocks away from deprecated mocha.