Properly escape bridge in rulename #144
Merged
+9
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is handled by the next - more specific - expect anyways
smortex
approved these changes
Aug 25, 2022
| @@ -10,7 +10,7 @@ | |||
| $bridges = $interfaces.filter |$items| { $items =~ $bridgenames } | |||
|
|
|||
| $bridges.each |String $bridge| { | |||
| $bridge_rulename = regsubst($bridge, '-', '_', 'G') | |||
| $bridge_rulename = regsubst($bridge, '-|:', '_', 'G') | |||
There was a problem hiding this comment.
For single char, I trend to prefer [] to | because it feels more readable:
Suggested change
| $bridge_rulename = regsubst($bridge, '-|:', '_', 'G') | |
| $bridge_rulename = regsubst($bridge, '[-:]', '_', 'G') |
That being said, a - is tricky in [] and we have two chars only so not a big deal.
kenyon
changed the title
traylenator
approved these changes
Aug 25, 2022
traylenator
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #143