Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow netdev as table family in defined type nftables::chain #149

Merged
merged 2 commits into from
Jan 29, 2023

Conversation

hugendudel
Copy link
Contributor

Allow netdev as table family in defined type nftables::chain

Hi all, we would like to use this module in combination with the netdev table family type.

Are there any objections?

This Pull Request (PR) fixes the following issues

n/a.

@traylenator
Copy link
Collaborator

@nbarrientos
Copy link
Collaborator

nbarrientos commented Jan 29, 2023

Thanks for the patch. I've added an acceptance test covering the new feature.

@nbarrientos nbarrientos self-requested a review January 29, 2023 17:16
Copy link
Collaborator

@nbarrientos nbarrientos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bastelfreak bastelfreak merged commit 509ef14 into voxpupuli:master Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants