Move ICMP stuff to separate classes allowing better customisation #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbarrientos
changed the title
nbarrientos
changed the title
|
API LGTM. |
|
Tests added (won't pass due to #15 blocking). |
|
Rebased, tests green and ready to be reviewed. Thanks! |
duritong
approved these changes
Nov 24, 2020
figless
pushed a commit
to figless/puppet-nftables
that referenced
this pull request
Aug 25, 2021
9246192 Merge pull request voxpupuli#16 from cernops/icmp 587e522 Merge pull request voxpupuli#20 from cernops/firewalld_mask ae9872e Make masking Service['firewalld'] configurable 79e9a23 Move ICMP stuff to separate classes git-subtree-dir: code git-subtree-split: 9246192
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to finish off #9. The patch moves all ICMP traffic management away from the
globalchain, creating specific input and output rules. RHEL8's defaults are followed.Users can customise the ICMP4/6 types to allow by providing values via Hiera to
nftables::rules::icmp::v4_typesand other similar parameters. One rule per type is added so it should be possible to add rates as part of the type, for instance:ICMP rule handling can completely be disabled by tweaking
nftables::in_icmpandnftables::out_icmp.Tests will be added if the proposed interface goes forward.Closes #9