README improvements #162
Merged
README improvements #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I couldn't figure out how to use this module when I looked at the
README. It was quickly going into pretty arcane stuff like "inet
filter" and "ip nat table" which might make sense for the module
authors or people used to nftables/iptables, but are pretty
implementation specific when coming from another networking
background.
Instead, we just explain more clearly what the module does, and
how. We also provide *more* examples, including some that might seem
obvious ("you need to include nftables first") but were not obvious to
me at all.
I also add a warning about firewalld being stopped which seems
important as well.
Closes: voxpupuli#158
smortex
approved these changes
Jan 30, 2023
I don't know what the nfc command is, but it certainly looks like a typo. Also, the flag to include a directory is `-I` here, not `-L`.
bastelfreak
approved these changes
Jan 30, 2023
duritong
approved these changes
Jan 30, 2023
|
Thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't figure out how to use this module when I looked at the
README. It was quickly going into pretty arcane stuff like "inet
filter" and "ip nat table" which might make sense for the module
authors or people used to nftables/iptables, but are pretty
implementation specific when coming from another networking
background.
Instead, we just explain more clearly what the module does, and
how. We also provide more examples, including some that might seem
obvious ("you need to include nftables first") but were not obvious to
me at all.
I also add a warning about firewalld being stopped which seems
important as well.
Closes: #158