Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bridge as a valid family for chain tables #165

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

luisfdez
Copy link

Pull Request (PR) description

Add bridge as a valid family to the regular expression validating the table parameter in the chain define.

This Pull Request (PR) fixes the following issues

Without this patch one cannot define chains belonging to tables of the bridge family as the validation of the table parameter blocks the input of names like bridge-filter.

@luisfdez luisfdez force-pushed the feat/bridge-chain branch 3 times, most recently from b145f6a to 7030bde Compare March 23, 2023 09:47
@luisfdez
Copy link
Author

Thanks @bastelfreak for fixing the reference.md. It was driving me crazy.

I tried with bundle exec rake strings:generate:reference.

Did you just use the puppet strings generate for the project?

@bastelfreak
Copy link
Member

bundle exec rake strings:generate:reference is fine, but you need puppet-strings 3. If you do bundle update it should be fine.

@bastelfreak bastelfreak merged commit cec8a7f into voxpupuli:master Mar 23, 2023
@bastelfreak bastelfreak added the enhancement New feature or request label Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants