Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example how to redirect one port to another #183

Merged
merged 1 commit into from Nov 22, 2023

Conversation

traylenator
Copy link
Collaborator

Pull Request (PR) description

Add example how to redirect traffic from one port to another.

@traylenator traylenator added the docs Improvements or additions to documentation label Jul 17, 2023
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is probably fine (maybe fix style), but instead of adding examples in the README maybe it worth adding examples in the examples directory? This allows to have acceptance tests where we exercise the examples code to ensure it applies correctly as a catalog, ensuring that these examples are still valid if the API happen to be changed:

https://github.com/voxpupuli/voxpupuli-acceptance#examples

manifests/rule.pp Outdated Show resolved Hide resolved
@traylenator
Copy link
Collaborator Author

traylenator commented Jul 18, 2023

That is probably fine (maybe fix style), but instead of adding examples in the README maybe it worth adding examples in the examples directory? This allows to have acceptance tests where we exercise the examples code to ensure it applies correctly as a catalog, ensuring that these examples are still valid if the API happen to be changed:

https://github.com/voxpupuli/voxpupuli-acceptance#examples

Re the examples I'll have a look next time ... else leave this here for a month or so and I'll have a go.
These examples will be a bit weird in that you need a lot of extra puppet code to actually disable nftables from really doing what it does since that is doomed to work in docker and the github runners. All it really does a nft syntax chcek but that is still very useful.

Add example how to redirect traffic from one port to another.
@traylenator traylenator merged commit 1085e99 into voxpupuli:master Nov 22, 2023
29 checks passed
@traylenator traylenator deleted the redirect branch November 22, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants