Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing unit string for timeout,gc-interval #187

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

javier-angulo
Copy link
Contributor

Pull Request (PR) description

Add unit string ("s") for timeout and gc-interval in set template.

This Pull Request (PR) fixes the following issues

Fixes #184

@smortex smortex changed the title fix #184: Add unit string for timeout,gc-interval Add missing unit string for timeout,gc-interval Jul 31, 2023
@smortex smortex added the bug Something isn't working label Jul 31, 2023
@smortex
Copy link
Member

smortex commented Jul 31, 2023

Looks good! The CI failure seems to be new (I guess we added this check recently)… Do you mind adding a commit to your PR that move these lines in manifests/init.pp before the ones with a default value in order to fix it:

Stdlib::Unixpath $echo,
Stdlib::Unixpath $configuration_path,
Stdlib::Unixpath $nft_path,
Stdlib::Filemode $default_config_mode,

@javier-angulo
Copy link
Contributor Author

Sure @smortex, will do.

Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smortex smortex merged commit 2ba59bc into voxpupuli:master Jul 31, 2023
24 checks passed
@javier-angulo javier-angulo deleted the fix/184 branch July 31, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set definition fail if timeout or gc_interval properties defined
2 participants