Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nftables::simplerule::dport - takes port ranges as part of the array #189

Merged
merged 6 commits into from
Nov 23, 2023

Conversation

tskirvin
Copy link
Contributor

@tskirvin tskirvin commented Aug 8, 2023

Pull Request (PR) description

Allows nftables::simplerule's dport to accept arrays of both ports and port ranges, and not just one or the other.

This Pull Request (PR) fixes the following issues

Fixes #188

@smortex
Copy link
Member

smortex commented Aug 8, 2023

REFERENCE.md is outdated

Please update REFERENCE.md with

$ bundle exec rake strings:generate:reference

Add it to the PR and CI should continue.

@tskirvin
Copy link
Contributor Author

tskirvin commented Aug 8, 2023

This is trickier on my RHEL7 build box than I was hoping; can you point me at a good getting-started page?

@duritong
Copy link
Collaborator

This is trickier on my RHEL7 build box than I was hoping; can you point me at a good getting-started page?

You have puppet agent installed on that box? You can use the ruby from puppet itself: /opt/puppetlabs/puppet/[....]/bin/bundle

@tskirvin
Copy link
Contributor Author

I was able to hack my way through to the REFERENCE.md changes.

@bastelfreak
Copy link
Member

@tskirvin please rebase against our latest master branch to get rid of the merge commit.

@tskirvin
Copy link
Contributor Author

Likes like it worked properly this time!

@tskirvin
Copy link
Contributor Author

tskirvin commented Nov 6, 2023

Any word on getting this merged into a full release and the forge?

@bastelfreak bastelfreak added the enhancement New feature or request label Nov 23, 2023
@bastelfreak bastelfreak merged commit b563353 into voxpupuli:master Nov 23, 2023
28 checks passed
@tskirvin
Copy link
Contributor Author

Thanks! I'm getting this rolled out on my systems soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nftables::simplerule - dport will take either an array of ports *or* a port range, but not both
5 participants