Rewrite mdns rules to limit to multicast and allow IPv6 #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This limits the mdns listener to only listen on multicast addresses with port 5353. One rule for IPv4 and one for IPv6, each controllable with a parameter. The generic 5353 to 5353 rule is dropped since it's redundant when I read [RFC6762]. [RFC6762]: https://www.rfc-editor.org/rfc/rfc6762
kenyon
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This limits the mdns listener to only listen on multicast addresses with port 5353. One rule for IPv4 and one for IPv6, each controllable with a parameter.
The generic 5353 to 5353 rule is dropped since it's redundant when I read RFC6762.