-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ftp helper #208
add ftp helper #208
Conversation
except the missing docstrings and thus the failing tests, this looks good to me. |
3bcc728
to
f728b4a
Compare
The way to credit co-authors is to use |
Thank you, amended |
manifests/helper.pp
Outdated
# @param helper | ||
# The symbolic name for the helper. | ||
define nftables::helper ( | ||
# lint:ignore:parameter_documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed? Looks like you have documented them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied it from an existing define. let me drop it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you forget to push your changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems that way. sigh. Hopefully that time is a charm
This adds ability to enable a connection tracker helper and provides typical ftp rules Co-authored-by: Vadym Chepkov <vchepkov@gmail.com> Co-authored-by: Yury Bushmelev <jay4mail@gmail.com>
This adds ability to enable a connection tracker helper and provides typical ftp rules