add ftp helper #208
Merged
add ftp helper #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
except the missing docstrings and thus the failing tests, this looks good to me. |
This was referenced Oct 28, 2023
bastelfreak
reviewed
Oct 28, 2023
vchepkov
force-pushed
the
ftp
branch
2 times, most recently
from
3bcc728
to
f728b4a
Compare
jay7x
approved these changes
Oct 29, 2023
duritong
reviewed
Oct 30, 2023
|
The way to credit co-authors is to use |
Thank you, amended |
ekohl
reviewed
Nov 3, 2023
manifests/helper.pp
Outdated
| # @param helper | ||
| # The symbolic name for the helper. | ||
| define nftables::helper ( | ||
| # lint:ignore:parameter_documentation |
There was a problem hiding this comment.
Why is this needed? Looks like you have documented them.
There was a problem hiding this comment.
I copied it from an existing define. let me drop it
There was a problem hiding this comment.
Did you forget to push your changes?
There was a problem hiding this comment.
it seems that way. sigh. Hopefully that time is a charm
This adds ability to enable a connection tracker helper and provides typical ftp rules Co-authored-by: Vadym Chepkov <vchepkov@gmail.com> Co-authored-by: Yury Bushmelev <jay4mail@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds ability to enable a connection tracker helper and provides typical ftp rules