New clobber_default_config paramater #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duritong
approved these changes
Jun 27, 2024
Certain OSes namely Debian and Archlinux provide default rules with the OS. This module has always respected those rules and appended all of its own rules to the end of the existing rules. The new parameter `clobber_default_config` if set `true` (default `false`) will drop any existing OS provided rules. Also related to acceptance tests only on Archlinux where the default OS provided configuration requires kernel >= 6.3 we purge the default rules if required.
traylenator
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Certain OSes namely Debian and Archlinux provide default rules with the OS.
This module has always respected those rules and appended all of its own rules to the end of the existing rules.
The new parameter
clobber_default_configif settrue(defaultfalse) will drop any existing OS provided rules.Also related to acceptance tests only on Archlinux where the default OS provided configuration requires kernel >= 6.3 we purge the default rules if required.
Fixes