Do not test nftables::rules repeatadly #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These tests pass but I am confused why. Shouldn't the nftables::rule for the bridge I'm missing something. If this is accepted I'll repeat this execise with other cases where nftables::rules and ::chains are being checked |
Rather than testing the contents of nftable::rules just test that nftables::rules instance is correct. The existing test for the define nftables::rules is enough. Motivation here is to make changes to nftables::rules easier to handle down the line.
traylenator
force-pushed
the
simplify
branch
from
6426302
to
300b738
Compare
|
Why is the passing test and not |
figless
pushed a commit
to figless/puppet-nftables
that referenced
this pull request
Aug 25, 2021
72aad4a Merge pull request voxpupuli#28 from traylenator/simplify 902ceaa Merge pull request voxpupuli#22 from cernops/log_limit 300b738 Do not test nftables::rules repeatadly b10c621 Set a customisable rate limit to the logging rules git-subtree-dir: code git-subtree-split: 72aad4a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than testing the contents of nftable::rules just test
that nftables::rules instance is correct.
The existing test for the define nftables::rules is enough.
Motivation here is to make changes to nftables::rules easier to handle
down the line.