Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ceph and NFS rules #32

Merged
merged 4 commits into from
Dec 2, 2020
Merged

Add Ceph and NFS rules #32

merged 4 commits into from
Dec 2, 2020

Conversation

dvanders
Copy link
Contributor

@dvanders dvanders commented Dec 1, 2020

No description provided.

@dvanders
Add ceph related rules
bbc93ed 
Signed-off-by: Dan van der Ster <daniel.vanderster@cern.ch>
@dvanders dvanders changed the title Add Ceph and NFS rules WIP: Add Ceph and NFS rules Dec 1, 2020
@dvanders dvanders marked this pull request as draft December 1, 2020 10:40
@dvanders
Add NFS-related rules
5210e02 
Signed-off-by: Dan van der Ster <daniel.vanderster@cern.ch>
@dvanders dvanders marked this pull request as ready for review December 1, 2020 12:55
@dvanders dvanders changed the title WIP: Add Ceph and NFS rules Add Ceph and NFS rules Dec 1, 2020
@traylenator
Copy link
Collaborator

Can you add some basic tests.

@dvanders
Test ceph rules
f4e9e99 
Signed-off-by: Dan van der Ster <daniel.vanderster@cern.ch>
@dvanders
Test NFS rules
d0c972c 
Signed-off-by: Dan van der Ster <daniel.vanderster@cern.ch>
@duritong
Copy link
Collaborator

duritong commented Dec 2, 2020

excellent looks good to me - @traylenator ?

@traylenator
Copy link
Collaborator

LGTM. +1

@duritong duritong merged commit ed8e464 into voxpupuli:master Dec 2, 2020
@traylenator traylenator added the enhancement New feature or request label Dec 10, 2020
figless pushed a commit to figless/puppet-nftables that referenced this pull request Aug 25, 2021
@nbarrientos
Squashed 'code/' changes from c3be15e..ed8e464
2ae2a0d 
ed8e464 Merge pull request voxpupuli#32 from dvanders/ceph_nfs
d0c972c Test NFS rules
f4e9e99 Test ceph rules
5210e02 Add NFS-related rules
bbc93ed Add ceph related rules

git-subtree-dir: code
git-subtree-split: ed8e464
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dvanders @traylenator @duritong