Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modulesync 4.0.0 #36

Merged
merged 8 commits into from
Dec 7, 2020
Merged

modulesync 4.0.0 #36

merged 8 commits into from
Dec 7, 2020

Conversation

traylenator
Copy link
Collaborator

@traylenator traylenator commented Dec 7, 2020 •
edited
Loading

First modulesync of puppet-nftables since migration.

  • modulesync 4.0.0
  • drop original .sync.yml with ~/.gitlab-ci.yml references
  • Remove puppet 4 support
  • lint fixes
  • prarameter definitions on one line.

ekohl
ekohl reviewed Dec 7, 2020
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we drop the PDK part as well:

puppet-nftables/metadata.json

Lines 49 to 51 in e3c56ff

"pdk-version": "1.18.1",
"template-url": "https://github.com/puppetlabs/pdk-templates#1.18.1",
"template-ref": "tags/1.18.1-0-g3d2e75c"

ekohl
ekohl reviewed Dec 7, 2020
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments are applicable in many places so I just commented once.

manifests/bridges.pp Outdated Show resolved Hide resolved
manifests/rules/icinga2.pp Outdated Show resolved Hide resolved
@traylenator
Copy link
Collaborator Author

In the abscence of CI testing , two test failiures.

  1) nftables nft rules present returns valid tables
     Failure/Error: Process.stubs(:uid).returns(0)
     
     NoMethodError:
       undefined method `stubs' for Process:Module
       Did you mean?  stub
     # ./spec/unit/facter/nftables_spec.rb:6:in `block (2 levels) in <top (required)>'
     # /usr/share/gems/gems/bundler-2.1.4/libexec/bundle:46:in `block in <top (required)>'
     # /usr/share/gems/gems/bundler-2.1.4/libexec/bundle:34:in `<top (required)>'

  2) nftables nft fails does not return a fact
     Failure/Error: Process.stubs(:uid).returns(0)
     
     NoMethodError:
       undefined method `stubs' for Process:Module
       Did you mean?  stub
     # ./spec/unit/facter/nftables_spec.rb:6:in `block (2 levels) in <top (required)>'
     # /usr/share/gems/gems/bundler-2.1.4/libexec/bundle:46:in `block in <top (required)>'
     # /usr/share/gems/gems/bundler-2.1.4/libexec/bundle:34:in `<top (required)>'

@ekohl
Copy link
Member

ekohl commented Dec 7, 2020 •
edited
Loading

In the abscence of CI testing , two test failiures.

The workaround is to push the branch to upstream. Then you can delete it. Github actions will continue to run after that, also on new pushes to your fork.

@traylenator
Copy link
Collaborator Author

puppet 4 refuses to go, guss the matrix is what is generated on the voxpupuli namespace.

@traylenator
Copy link
Collaborator Author

@ekohl many thanks - think I have run out of things to do in this first pass.

@traylenator traylenator merged commit 7db6f79 into voxpupuli:master Dec 7, 2020
@traylenator traylenator deleted the modulesync branch December 7, 2020 16:23
figless pushed a commit to figless/puppet-nftables that referenced this pull request Aug 25, 2021
@nbarrientos
Squashed 'code/' changes from e3c56ff..7db6f79
19a886c 
7db6f79 Merge pull request voxpupuli#36 from traylenator/modulesync
4630574 Correct author, add tags and issues to metadata
5b4c71b Correctly remove puppet4 support
31b1762 Use single line for each parameter definition
59c1ddf Mock with mocha
b09d43b Adapt metadata to voxpupuli name space
11bf723 lint_fix results
78f2281 modulesync 4.0.0
8897f7d Drop duritong .sync.yml

git-subtree-dir: code
git-subtree-split: 7db6f79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@traylenator @ekohl