Check that all the predefined rules are declared in the all rules acceptance test #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbarrientos
changed the title
traylenator
reviewed
Dec 11, 2020
There was a problem hiding this comment.
This will be overwritten by modulesync.
Looking at the template https://github.com/voxpupuli/modulesync_config/blob/master/moduleroot/.github/workflows/ci.yml.erb
There is no parameter to add extra tests which there used to be with the old Travis templates I think. (Maybe confusing with our own templates).
Will try and extend the templates. |
traylenator
approved these changes
Dec 11, 2020
|
🤷 |
traylenator
reviewed
Dec 14, 2020
traylenator
requested changes
Dec 14, 2020
nbarrientos
force-pushed
the
allrules_check
branch
2 times, most recently
from
496321c
to
c618852
Compare
nbarrientos
force-pushed
the
allrules_check
branch
from
c618852
to
c3f6e1f
Compare
traylenator
approved these changes
Jan 18, 2021
figless
pushed a commit
to figless/puppet-nftables
that referenced
this pull request
Aug 25, 2021
afc4dd1 Release 1.1.0 (voxpupuli#67) cad7d4c Merge pull request voxpupuli#60 from duritong/more_mail_client_rules 19908f4 add some mail related outgoing rules 2827108 Merge pull request voxpupuli#63 from traylenator/badges e2031b3 Merge pull request voxpupuli#64 from traylenator/params e977eb3 Merge pull request voxpupuli#62 from glpatcern/master 09cba18 Enable parameter_documentation lint 354a82d Removed unneeded parentheses 82b6fd5 Add badges to README 4470f70 Updated docs 6587545 Merge pull request voxpupuli#53 from cernops/allrules_check e743f82 Made ctdb rule parameterized c3f6e1f Use a separate job file 3246b96 Check that all rules are declared in the all rules acceptance test beaf4ee Merge pull request voxpupuli#59 from cernops/issue58 8c00b81 Pull up rule regexp to type aliases 1ee2f66 Added to tests a6f61c6 Added Samba in rules 6a4ffea Align simplerule and rule rulename requirements 2bcfc1a [blacksmith] Bump version to 1.0.1-rc0 git-subtree-dir: code git-subtree-split: afc4dd1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be seen in action here: https://github.com/voxpupuli/puppet-nftables/pull/54/checks?check_run_id=1537808159