Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Samba in rules #62

Merged
merged 5 commits into from
Jan 18, 2021
Merged

Add Samba in rules #62

merged 5 commits into from
Jan 18, 2021

Conversation

glpatcern
Copy link
Contributor

@glpatcern glpatcern commented Jan 18, 2021

Pull Request (PR) description

These are the nft in rules to operate a Samba cluster, including ctdb. Tested at CERN.
The ctdb opening is optional and a parameter is provided for that.

This Pull Request (PR) fixes the following issues

N/A

@nbarrientos nbarrientos added the enhancement New feature or request label Jan 18, 2021
@glpatcern glpatcern marked this pull request as draft January 18, 2021 11:29
manifests/rules/samba.pp Outdated Show resolved Hide resolved
Co-authored-by: Nacho Barrientos <nacho@criptonita.com>
Copy link
Collaborator

@nbarrientos nbarrientos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for the patch! The REFERENCE can be regenerated later on. Asking for a second opinion, though.

manifests/rules/samba.pp Outdated Show resolved Hide resolved
@bastelfreak bastelfreak merged commit e977eb3 into voxpupuli:master Jan 18, 2021
@bastelfreak bastelfreak changed the title Added Samba in rules Add Samba in rules Jan 18, 2021
figless pushed a commit to figless/puppet-nftables that referenced this pull request Aug 25, 2021
afc4dd1 Release 1.1.0 (voxpupuli#67)
cad7d4c Merge pull request voxpupuli#60 from duritong/more_mail_client_rules
19908f4 add some mail related outgoing rules
2827108 Merge pull request voxpupuli#63 from traylenator/badges
e2031b3 Merge pull request voxpupuli#64 from traylenator/params
e977eb3 Merge pull request voxpupuli#62 from glpatcern/master
09cba18 Enable parameter_documentation lint
354a82d Removed unneeded parentheses
82b6fd5 Add badges to README
4470f70 Updated docs
6587545 Merge pull request voxpupuli#53 from cernops/allrules_check
e743f82 Made ctdb rule parameterized
c3f6e1f Use a separate job file
3246b96 Check that all rules are declared in the all rules acceptance test
beaf4ee Merge pull request voxpupuli#59 from cernops/issue58
8c00b81 Pull up rule regexp to type aliases
1ee2f66 Added to tests
a6f61c6 Added Samba in rules
6a4ffea Align simplerule and rule rulename requirements
2bcfc1a [blacksmith] Bump version to 1.0.1-rc0

git-subtree-dir: code
git-subtree-split: afc4dd1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants