Add a parameter to control the fate of discarded traffic #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM @keachi wdyt |
duritong
approved these changes
Nov 16, 2020
keachi
requested changes
Nov 16, 2020
figless
pushed a commit
to figless/puppet-nftables
that referenced
this pull request
Aug 25, 2021
5e0146c Merge pull request voxpupuli#7 from cernops/reject_with 7072774 Add a parameter to control the fate of discarded packets git-subtree-dir: code git-subtree-split: 5e0146c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements the second feature requested via #2, adding a parameter to configure how discarded packets will be handled. By default, they'll be rejected by the last rule in each chain with
icmpx type port-unreachableas it's always been, however it's possible now to set the parameter tofalseso the packets are handled instead via the policies of the chains which at the moment are alldrop.Closes #2.