Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow raw sets and dashes in set names #8

Merged
merged 2 commits into from
Nov 18, 2020
Merged

Allow raw sets and dashes in set names #8

merged 2 commits into from
Nov 18, 2020

Conversation

nbarrientos
Copy link
Collaborator

This patchset does two things:

  • Relax the parameter type of the defined type nftables::set so it does not have to be always set, allowing to define a set passing raw input using source or content (see tests)
  • Allow dashes to be part of set names.

@nbarrientos
Relax nftables::set::type making it optional
9f0498e 
This is needed in case nftables::set is passed raw configuration via
source or content.
@nbarrientos
Allow dashes in set names
7bb485c
@nbarrientos nbarrientos changed the title Allow raw sets and allow dashes in set names Allow raw sets and dashes in set names Nov 16, 2020
duritong
duritong requested changes Nov 18, 2020
View reviewed changes
Copy link
Collaborator

@duritong duritong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the minor comment about escaping, all good.

manifests/set.pp Show resolved Hide resolved
@duritong duritong merged commit ef3e9ad into voxpupuli:master Nov 18, 2020
@nbarrientos
Copy link
Collaborator Author

Thanks for the review!

@traylenator traylenator added the enhancement New feature or request label Dec 10, 2020
figless pushed a commit to figless/puppet-nftables that referenced this pull request Aug 25, 2021
@nbarrientos
Squashed 'code/' changes from 5e0146c..ef3e9ad
cdd3ccb 
ef3e9ad Merge pull request voxpupuli#8 from cernops/ai5973
7bb485c Allow dashes in set names
9f0498e Relax nftables::set::type making it optional

git-subtree-dir: code
git-subtree-split: ef3e9ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duritong duritong duritong requested changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nbarrientos @duritong @traylenator