-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rules for QEMU/libvirt guests (bridged virtual networking) #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddca373
to
857b480
Compare
0a92595
to
769408e
Compare
traylenator
previously approved these changes
Mar 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff.
bastelfreak
reviewed
Mar 23, 2021
bastelfreak
previously approved these changes
Mar 23, 2021
duritong
previously approved these changes
Mar 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs rebase otherwise lgtm
cd2a3cb
Needs approval again after rebasing, one should do. |
duritong
approved these changes
Mar 25, 2021
Thanks, @duritong |
figless
pushed a commit
to figless/puppet-nftables
that referenced
this pull request
Aug 25, 2021
cae7912 Merge pull request voxpupuli#86 from cernops/release_1_3_0 804b96e Prepare release 1.3.0 3f2f50c Merge pull request voxpupuli#85 from cernops/qemu cd2a3cb Add rules for QEMU/libvirt guests 18b211e Merge pull request voxpupuli#80 from luisfdez/dockerce 1bf717d Add optional handling of chains c86e270 Merge pull request voxpupuli#84 from traylenator/version 4d95ea8 Add fact section to README.md 9dca9bc Fix doc defaults 032387d Add nftables.version to structured fact. b61ccb4 Fix rulename spec in spec 283e1c3 Fix syntax c351549 Add newline & more tests 6be2adf Add Docker-CE default rules 7a77d75 Merge pull request voxpupuli#82 from cernops/ibarrien_activemq 771b325 Add rules for Apache ActiveMQ 502b9da Merge pull request voxpupuli#81 from cernops/emacs_readme b1b6150 Add pointer to Yasnippets for some defined types 2fda87a Improve sections' formatting 812ca77 Release 1.2.1-rc0 (voxpupuli#77) git-subtree-dir: code git-subtree-split: 7b8e4635092853a892bd247a05e0025492262b6a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.