Fix IPv4 source address type detection #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch, a rule like this:
```
nftables::simplerule { 'foo':
action => 'accept',
dport => 443,
proto => 'tcp4',
saddr => '192.168.1.10',
}
```
would incorrectly generate this rule:
```
ip version 4 tcp dport {443} ip6 saddr 192.168.1.10 accept
```
Note the 'ip6 saddr'.
duritong
approved these changes
Apr 26, 2021
figless
pushed a commit
to figless/puppet-nftables
that referenced
this pull request
Aug 25, 2021
1d9033d Release 2.0.1-rc0 0c4f8de Merge pull request voxpupuli#97 from cernops/release_140 683d104 Prepare release 2.0.0 65b4f2f Merge pull request voxpupuli#96 from cernops/issue95 7b9d6ff Allow creating a totally empty firewall 4937bed Merge pull request voxpupuli#93 from cernops/ibarrien_saddr bd8baa0 Fix IPv4 source address type detection a8008e4 Merge pull request voxpupuli#92 from traylenator/everything 1eda6ef Rely on puppet 6 calling daemon-reload ad042d5 Merge remote-tracking branch 'kenyon/bump-concat' into everything 42c426c puppetlabs/concat: Allow 7.x 9b6d7f0 puppetlabs/stdlib: Allow 7.x af33f65 camptocamp/systemd: allow 3.x f82aaa5 Merge pull request voxpupuli#88 from cernops/dotfiles_yas_link 693a3d9 Amend link to Yasnippets 89d99b8 Merge pull request voxpupuli#87 from cernops/bump_rc bbdcfb2 Release 1.3.1-rc0 242df53 metadata.json: drop Puppet 5 support git-subtree-dir: code git-subtree-split: 1d9033d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, a rule like this:
would incorrectly generate this rule:
Note the
ip6 saddr.