Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssl_dhparam no longer an option #1084

Closed
sk33lz opened this issue May 4, 2017 · 2 comments
Closed

ssl_dhparam no longer an option #1084

sk33lz opened this issue May 4, 2017 · 2 comments

Comments

@sk33lz
Copy link

sk33lz commented May 4, 2017

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 4.10.0
  • Ruby: ruby 2.0.0p648
  • Distribution: Ubuntu 16.04
  • Module version: 0.6.0

How to reproduce (e.g Puppet code you use)

Add ssl_dhparam => '/path/to/dh.params.file', to a manifest file that has SSL enabled.

What are you seeing

You can no longer use the ssl_dhparam option in a manifest file in the puppet/nginx module, as it's not defined in the module.

What behaviour did you expect instead

In the jfryman/nginx 0.3.0 version of this module you could setup an ssl_dhparam option for SSL that adds Diffie–Hellman key exchange for SSL.

@wyardley
Copy link
Collaborator

wyardley commented May 4, 2017

Can you show the exact declaration you're using? It appears to be supported, e.g., https://github.com/voxpupuli/puppet-nginx/blob/master/manifests/resource/server.pp#L44

https://github.com/voxpupuli/puppet-nginx/blob/master/templates/server/server_ssl_settings.erb#L13-L15

the mailhost resource has similar settings.

@sk33lz
Copy link
Author

sk33lz commented May 4, 2017

You are right. It helps if I generate the pem file locally first :| Thanks!

@sk33lz sk33lz closed this as completed May 4, 2017
@alexjfisher alexjfisher added wont-fix This will not be worked on invalid and removed wont-fix This will not be worked on labels Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants