Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[warn] the "ssl" directive is deprecated, use the "listen ... ssl" directive instead #1224

Closed
bastelfreak opened this issue Jul 7, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@bastelfreak
Copy link
Member

commented Jul 7, 2018

The ssl on syntax is deprecated since nginx 1.15. We should only add it if we use nginx 1.14 or older.

@bastelfreak bastelfreak added the bug label Jul 7, 2018

bastelfreak added a commit to bastelfreak/puppet-nginx that referenced this issue Jul 7, 2018

dont deploy "ssl on" on nginx 1.15 an newer
fixes voxpupuli#1224. the option 'ssl on' within a server block is deprecated since nginx 1.15.0.

bastelfreak added a commit to bastelfreak/puppet-nginx that referenced this issue Jul 7, 2018

dont deploy "ssl on" on nginx 1.15 or newer
fixes voxpupuli#1224. the option 'ssl on' within a server block is deprecated since nginx 1.15.0.

bastelfreak added a commit to bastelfreak/puppet-nginx that referenced this issue Jul 7, 2018

dont deploy "ssl on" on nginx 1.15 or newer
fixes voxpupuli#1224. the option 'ssl on' within a server block is deprecated since nginx 1.15.0.

bastelfreak added a commit to bastelfreak/puppet-nginx that referenced this issue Jul 7, 2018

dont deploy "ssl on" on nginx 1.15 or newer
fixes voxpupuli#1224. the option 'ssl on' within a server block is deprecated since nginx 1.15.0.

bastelfreak added a commit to bastelfreak/puppet-nginx that referenced this issue Jul 7, 2018

dont deploy "ssl on" on nginx 1.15 or newer
fixes voxpupuli#1224. the option 'ssl on' within a server block is deprecated since nginx 1.15.0.
@PierreR

This comment has been minimized.

Copy link
Contributor

commented Oct 17, 2018

@bastelfreak Could you explain why we use a fact to retrieve the nginx_version instead of a params defined by the user ? Thanks.

@bastelfreak

This comment has been minimized.

Copy link
Member Author

commented Oct 17, 2018

Because the fact actually represents the installed version, and not a version a user might want to have. Are you running into any issues with this?

@PierreR

This comment has been minimized.

Copy link
Contributor

commented Oct 17, 2018

@bastelfreak No issue in particular. Just curious and a bit surprised as I am actually using the module to install nginx. In that case it seems a bit weird to have to go to the machine to check on the installed version.

Thanks for your quick reply !

ceonizm added a commit to ceonizm/puppet-nginx that referenced this issue Jan 23, 2019

dont deploy "ssl on" on nginx 1.15 or newer
fixes voxpupuli#1224. the option 'ssl on' within a server block is deprecated since nginx 1.15.0.

ceonizm added a commit to ceonizm/puppet-nginx that referenced this issue Jan 23, 2019

dont deploy "ssl on" on nginx 1.15 or newer
fixes voxpupuli#1224. the option 'ssl on' within a server block is deprecated since nginx 1.15.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.