Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy_redirect default value #395

Closed
mks-m opened this issue Aug 8, 2014 · 2 comments
Closed

proxy_redirect default value #395

mks-m opened this issue Aug 8, 2014 · 2 comments

Comments

@mks-m
Copy link
Contributor

mks-m commented Aug 8, 2014

i'm not sure what is the rationale behind making default value for proxy_redirect off but it is different from default value default used by nginx itself when the option is not present in config file. http://nginx.org/en/docs/http/ngx_http_proxy_module.html#proxy_redirect

also it looks like default value in params.pp was undef and option was omitted unless a non-nil value was passed - was there a reason to change that?

@wyardley
Copy link
Collaborator

wyardley commented Oct 8, 2016

I agree that more values should just be set to undef (to allow them to get the default setting). I'm not sure why config.pp has it default to 'off'.

@3flex @bastelfreak: anyone object to switching it to either 'undef' or 'on'?

@wyardley
Copy link
Collaborator

Better late than never, I guess?
Seems like as good a place as any for the 'start making certain values default' (#896) changes...
#948

bastelfreak added a commit that referenced this issue Oct 31, 2016
default proxy_redirect to undef in locations (resolves #395)
cegeka-jenkins pushed a commit to cegeka/puppet-nginx that referenced this issue Sep 13, 2019
cegeka-jenkins pushed a commit to cegeka/puppet-nginx that referenced this issue Sep 13, 2019
…ssues_395

default proxy_redirect to undef in locations (resolves voxpupuli#395)
Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this issue Oct 19, 2020
Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this issue Oct 19, 2020
…ssues_395

default proxy_redirect to undef in locations (resolves voxpupuli#395)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants