Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redundant "maintenance" code applied to every vhost #602

Closed
3flex opened this issue Apr 13, 2015 · 0 comments · Fixed by #606
Closed

redundant "maintenance" code applied to every vhost #602

3flex opened this issue Apr 13, 2015 · 0 comments · Fixed by #606
Labels
bug Something isn't working

Comments

@3flex
Copy link
Contributor

3flex commented Apr 13, 2015

This code is unnecessarily added to every vhost:

  if ($maintenance = "on") {
      <%= @maintenance_value %>;
  }

But it only does anything when maintenance => on is on. Introduced by #578 & #584.
@3flex 3flex added the bug Something isn't working label Apr 13, 2015
@3flex 3flex mentioned this issue Apr 14, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vhost: simplify maintenance variable code
1 participant
@3flex