Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version no longer works on DragonFlyBSD #619

Closed
strangelittlemonkey opened this issue Apr 30, 2015 · 4 comments · Fixed by #635
Closed

Latest version no longer works on DragonFlyBSD #619

strangelittlemonkey opened this issue Apr 30, 2015 · 4 comments · Fixed by #635
Labels
enhancement New feature or request

Comments

@strangelittlemonkey
Copy link
Contributor

Partially due to the params.pp being used now and not mentioning DragonFly, which I can fix in a couple minutes, but something deeper was changed that's now generating an invalid config even when that's not an issue. I'll try to get it functional again and send a pull request. Any help along the way would be greatly appreciated.

@strangelittlemonkey
Copy link
Contributor Author

Ok. It seems if you don't have a /var/log/nginx directory it will not make one, but instead just fail. Should I address that in the pull request as well?

@3flex
Copy link
Contributor

3flex commented Apr 30, 2015

Did some research: Dragonfly is a fork of FreeBSD. In FreeBSD the following log files are used for nginx by default:

  • Access log: /var/log/nginx-access.log
  • Error log: /var/log/nginx-error.log

I'd expect DragonFly to be the same. So what should happen ideally is that the logdir is set to /var/log for both FreeBSD and DragonFlyBSD to reflect the distribution default, and the default log file names should be as above. There should be no need for this module to create a log directory in this case.

Are you up to creating a PR to cover that?

@strangelittlemonkey
Copy link
Contributor Author

When I put 'FreeBSD', 'DragonFlyBSD':, it wanted to make /var/log/nginx/[access|error].log. I can take care of that too though.

@3flex 3flex added the enhancement New feature or request label May 20, 2015
@3flex
Copy link
Contributor

3flex commented Jun 1, 2015

@strangelittlemonkey not sure if you're still working on this, but there's active conversation in #635 and I don't want your submission and #635 to duplicate any work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants