Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying keepalive and least_conn in upstream gives warning. #641

Closed
IslandUsurper opened this issue Jun 10, 2015 · 3 comments
Closed
Assignees

Comments

@IslandUsurper
Copy link

nginx would prefer that directives like ip_hash and least_conn would come before keepalive in an upstream section. But sorting the keys of $upstream_cfg_prepend makes that problematic.

It's only a warning, so it's only annoying as opposed to something more serious, but it would be good not to have it show up.

@wyardley wyardley self-assigned this Nov 2, 2016
@wyardley
Copy link
Collaborator

wyardley commented Nov 2, 2016

Having both upstream_cfg_append and upstream_cfg_prepend now (#953) may help a bit (you could use append only for the keepalive, but that seems kind of hackish); I can see if we can do something similar to
https://github.com/voxpupuli/puppet-nginx/blob/master/templates/vhost/vhost_header.erb#L91
if it helps, though of course if you put keepalive in the prepend and then something else in append, it will go after.

@wyardley
Copy link
Collaborator

wyardley commented Nov 2, 2016

@IslandUsurper btw, can you include an example that will generate the config w/ the warning?

@wyardley
Copy link
Collaborator

#969 should address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants