Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove $configtest_enable parameter, look into nginx::service in general #916

Closed
wyardley opened this issue Oct 11, 2016 · 1 comment
Closed

Comments

@wyardley
Copy link
Collaborator

When looking into #722, it looks like
https://github.com/voxpupuli/puppet-nginx/blob/master/manifests/service.pp#L63-L66
and related parameters are totally broken (though strangely, I'm having a hard time actually . This code should be looked at and simplified, and the $configtest_enable param should probably be taken out (many systems already do this in their init scripts anyway).

I really don't see how the existing nginx::service is working at all, need to look at it more closely.

@tux-o-matic
Copy link

@wyardley part of the problem is that the module today is depending on an init/systemd script which is not managed by the module.
Since Nginx only recently added some sort of dynamic module loading, compiling Nginx isn't that unusual and there for setting the service script is left up to you.

So in service.pp, it's optional because some script might not have reload (not a standard initd function like restart) and some use cases might want to use restart rather than reload, each using a specific kill signal. But the module design today makes some the assumptions about restart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants