Avoid spurious location block when redirecting to SSL in another server block #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oranenj I think this looks sane from a quick read, though I wonder if there's a way to rework the logic to be a bit easier to read |
|
@wyardley: The current logic is a bit hard to keep track of, yes, but I think the location resource works as it should. At least, I didn't spot any obvious issues with it. Refactoring the whole thing would take more effort than I have time to spend on this at the moment. :/ |
|
@oranenj Yeah, no worries! From my end this looks good, but would like to see another reviewer as well. |
wyardley
reviewed
Apr 10, 2017
juniorsysadmin
approved these changes
Apr 13, 2017
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Sep 13, 2019
Avoid spurious location block when redirecting to SSL in another server block
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
Avoid spurious location block when redirecting to SSL in another server block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1029
I'm pretty sure this is sane behaviour. Any thoughts?