Fix syntax error in ERB template for fastcgi location. #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a syntax error in the generated ruby script of this erb file.
Using ruby version `2.5.0p0 (2017-12-25 revision 61468) [x86_64-linux]` and erb version `erb.rb [2.1.0 2017-12-22]`,
the erb template was being converted into the following ruby code:
```
if defined? @fastcgi_script
); @fastcgi_param = { 'SCRIPT_FILENAME' => @fastcgi_script }.merge(@fastcgi_param || {})
end
```
which resulted in the following error when doing a syntax check with `ruby -c`:
```
-:19: syntax error, unexpected ')'
); @fastcgi_param = { 'SCRIPT...
^
```
With this commit applied, the converted ruby code will look like this:
```
if defined? @fastcgi_script
_erbout.<<(-" "); _erbout.<<(-"\n"
); @fastcgi_param = { 'SCRIPT_FILENAME' => @fastcgi_script }.merge(@fastcgi_param || {})
end
```
which is now correct ruby code.
alexjfisher
approved these changes
Jan 10, 2018
|
@rpasing Thanks! |
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
Fix syntax error in ERB template for fastcgi location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix syntax error in ERB template for fastcgi location.
This commit fixes a syntax error in the generated ruby script of this erb file.
Using ruby version
2.5.0p0 (2017-12-25 revision 61468) [x86_64-linux]and erb versionerb.rb [2.1.0 2017-12-22], the erb template was being converted into the following ruby code:which resulted in the following error when doing a syntax check with
ruby -c:With this commit applied, the converted ruby code will look like this:
which is now correct ruby code.