Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow people to not purge passenger yumrepo #1212

Merged
merged 1 commit into from
May 11, 2018

Conversation

bastelfreak
Copy link
Member

The idea is that people can switch between the different available nginx
repos. in case somebody switched from the passenger one to the upstream
repo we want to purge the passenger repo. However this gets us intro
trouble if the person never switched, but another module declares a
resource with this name.

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@bastelfreak bastelfreak added the bug Something isn't working label May 10, 2018
The idea is that people can switch between the different available nginx
repos. in case somebody switched from the passenger one to the upstream
repo we want to purge the passenger repo. However this gets us intro
trouble if the person never switched, but another module declares a
resource with this name.
Copy link
Member

@alexjfisher alexjfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could do with documenting, but none of the other base class parameters seem to be documented, so meh.

@bastelfreak bastelfreak merged commit 7918ecc into voxpupuli:master May 11, 2018
@bastelfreak bastelfreak deleted the purgerepo branch May 11, 2018 08:04
Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this pull request Oct 19, 2020
allow people to not purge passenger yumrepo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants