Use HTTPS for Yum repositories #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
approved these changes
Jul 26, 2018
ekohl
requested changes
Jul 26, 2018
|
origin was up to date, but I totally missed the specs. Test still fail though, with (seemingly?) unrelated errors |
|
Ah, #1235 hasn't been merged yet. |
|
I subscribed to #1235 so I'll hopefuly catch when it is merged. Once this is done I'll do a rebase. |
|
That's merged now :) |
|
Rebased, now the tests worked as well! |
ekohl
approved these changes
Jul 30, 2018
|
Thanks! |
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
Use HTTPS for Yum repositories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Use HTTPS instead of HTTP for yum repositories
This Pull Request (PR) fixes the following issues
None. I actually implemented it because I use this module from a location where only HTTPS is required, but it's good practice to use HTTPS when available anyway!