Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autoindex to ssl_header too #1275

Merged
merged 5 commits into from
Dec 15, 2018
Merged

Add autoindex to ssl_header too #1275

merged 5 commits into from
Dec 15, 2018

Conversation

bc-bjoern
Copy link
Contributor

Hello,

the option autoindex was missing in server_ssl_header.erb.

Thanks!

@ekohl
Copy link
Member

ekohl commented Nov 13, 2018

Could you add a test for this?

@bc-bjoern
Copy link
Contributor Author

May be...

@bc-bjoern bc-bjoern closed this Nov 14, 2018
@bc-bjoern
Copy link
Contributor Author

bc-bjoern commented Nov 14, 2018

Okay, I can't.

@ekohl
Copy link
Member

ekohl commented Nov 14, 2018

Feel free to keep the PR open and add commits to it. If you need help with writing a test we're happy to help.

@bc-bjoern
Copy link
Contributor Author

I do not understand this unfortunately. I guess I need to add it in spec/defines/resource_server_spec.rb in line 439 "describe server_ssl_header template content". But I do not understand how to do it correctly.

@bc-bjoern bc-bjoern reopened this Nov 14, 2018
@ekohl
Copy link
Member

ekohl commented Nov 14, 2018

It would be very similar to:

{
title: 'should set index_file(s)',
attr: 'index_files',
value: %w[name1 name2],
match: %r{\s*index\s+name1\s+name2;}
},

That's where we test the SSL part of it. You can copy that one and modify it to autoindex instead of index_files.

@bc-bjoern
Copy link
Contributor Author

Sure, this part is clear more or less.

           [    
             {    
               title: 'should set autoindex',
               attr: 'autoindex',
               value: 'on',
               match: '  autoindex on;'
             }    
           ] 

But I didn't managed it to include this into the server_ssl_header section.

@bc-bjoern
Copy link
Contributor Author

Travis says no

@ekohl ekohl merged commit 3f1893e into voxpupuli:master Dec 15, 2018
@ekohl
Copy link
Member

ekohl commented Dec 15, 2018

Thanks!

@ekohl ekohl added the enhancement New feature or request label Dec 15, 2018
ceonizm pushed a commit to ceonizm/puppet-nginx that referenced this pull request Jan 23, 2019
ceonizm pushed a commit to ceonizm/puppet-nginx that referenced this pull request Jan 23, 2019
cegeka-jenkins pushed a commit to cegeka/puppet-nginx that referenced this pull request Sep 13, 2019
Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this pull request Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants