Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update smartos support #1290

Merged
merged 2 commits into from
Dec 28, 2018
Merged

Update smartos support #1290

merged 2 commits into from
Dec 28, 2018

Conversation

joelgarboden
Copy link

Pull Request (PR) description

Update SmartOS support, which is in the Solaris family.

facter -p os
{"name"=>"SmartOS", "family"=>"Solaris", "release"=>{"minor"=>"11", "full"=>"5.11"}}

This Pull Request (PR) fixes the following issues

SmartOS is in the Solaris family, so was never reaching the $facts['os']['family'] default case, but instead landing in Solaris.

In addition, /usr is read-only on SmartOS, but not Solaris.

Tested on a Base-64 17.4.0-LTS zone, initially setup by 0.9.0 version of this module.

@juniorsysadmin juniorsysadmin added the enhancement New feature or request label Dec 25, 2018
@bastelfreak
Copy link
Member

Hi @joelgarboden, thanks for this PR! Any chance you could provide facts from smartos to https://github.com/camptocamp/facterdb ?

@bastelfreak bastelfreak merged commit 42dfb05 into voxpupuli:master Dec 28, 2018
@joelgarboden joelgarboden deleted the update_smartos_support branch December 28, 2018 18:23
cegeka-jenkins pushed a commit to cegeka/puppet-nginx that referenced this pull request Sep 13, 2019
Rubueno pushed a commit to Rubueno/puppet-nginx that referenced this pull request Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants