Fix IPv6 adresses in upstream members #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Jan 18, 2019
silkeh
force-pushed
the
fix-ipv6-upstream-member
branch
from
61e8efc
to
6f94d09
Compare
|
Not sure why the tests are failing, but it seems to be unrelated to changes introduced by this PR. |
IPv6 addresses, when used in conjunction with a port, need to be enclosed by square brackets (`[]`).
Stdlib 4.25.0 introduces `Stdlib::IP::Address::V6` used for checking if an IP address is an IPv6 address.
bastelfreak
force-pushed
the
fix-ipv6-upstream-member
branch
from
6f94d09
to
f24fe69
Compare
|
Hi @silkeh, I rebased this branch. The tests should turn green afterwards. If they do, I will merge the PR. Thanks for the work! |
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
Fix IPv6 adresses in upstream members
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
IPv6 addresses, when used in conjunction with a port, need to be
enclosed by square brackets (
[]).This PR checks if the server is an IPv6 address, and encloses it in brackets when it is.
Includes a bump of the minimum version of stdlib, as
Stdlib::IP::Address::V6was introduced in version v4.25.0.This Pull Request (PR) fixes the following issues
Fixes #1299