Fix $nginx_upstreams_defaults type
#1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add some tests, so we know that the issue is fixed? |
|
@bastelfreak By simple inspection, I think we can be pretty sure this is correct though. |
alexjfisher
approved these changes
Feb 9, 2019
alexjfisher
changed the title
$nginx_upstream_defaults type
In my understanding, `$nginx_upstream_defaults` should be of type `UpstreamDefaults`, not `UpstreamMemberDefaults`.
|
ah, looks like we both updated it @alexjfisher :D |
bastelfreak
changed the title
$nginx_upstream_defaults type$nginx_upstreams_defaults type
|
@saz Thanks for finding this! Sorry for the silly number of force pushes to your PR branch. First I didn't know both @bastelfreak and me were simultaneously working on getting this merged. I also hadn't noticed the parameter got renamed in #1080! :) Should be correct and merged now. Thanks again. |
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
Fix `$nginx_upstream_defaults` type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
In my understanding, $nginx_upstream_defaults should be of type UpstreamDefaults, not UpstreamMemberDefaults